Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deprecated functional tests rest transport options #255

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix: Deprecated functional tests rest transport options #255

merged 1 commit into from
Apr 22, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Apr 21, 2020

Fixes #254

@abmusse abmusse requested a review from kadler April 21, 2020 23:49
kadler
kadler approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, though with all the duplication it seems like an opportunity to consolidate it in one place in the future.

@kadler kadler merged commit 903dd3f into master Apr 22, 2020
@kadler kadler deleted the fix-deprecated-functional-tests-rest-options branch April 22, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated functional test rest options are incorrect
2 participants
@abmusse @kadler