Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Homepage link in package.json #267

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix: Homepage link in package.json #267

merged 1 commit into from
Apr 23, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Apr 23, 2020

Fixes #266

@abmusse abmusse requested a review from kadler April 23, 2020 18:57
kadler
kadler reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand wanting to make it easy to point the user directly to the readme, but it does seem a bit odd to me.

@abmusse
Copy link
Member Author

abmusse commented Apr 23, 2020

This was the suggestion here https://docs.npmjs.com/files/package.json#homepage

kadler
kadler approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If npm recommends it, who am I to argue?

@abmusse abmusse merged commit d5787ce into master Apr 23, 2020
@kadler kadler deleted the fix-package.json-homepage branch April 24, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update homepage property in package.json
2 participants
@abmusse @kadler