Fix nzpy query hang issue: handle 'Z' after error #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: #33
Problem:When query receives an error from backend(i.e. backend response 'E'), after processing error we are not consuming response 'Z' from backend. These bytes remain on socket and causes reading incorrect data for next query and thereby causing nzpy to hang.
Solution: After handling character 'E' from backend continue listening to backend for 'Z' and consume the response.
Testing: Issue happened when running nzbatchbnr testcase or nzalchemy+nzpy testcase. After fix, ran same testcase and issue was not observed.