-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in Job condition check #74
Conversation
Failures from the test appear unrelated to my changes, or am I missing something?
|
4995433
to
dadd918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pit1sIBM it looks like you're getting unlucky. pygit2 released a new version and now we're breaking. I can opened another PR to pin it to under |
PR opened: #75 |
Signed-off-by: Zac Pitones <zac.pitones@ibm.com>
Thanks @HonakerM @gabe-l-hart sorry for the trouble |
Not a problem, thanks for the fix! |
Related Issue
Supports #ISSUE_NUMBER
Related PRs
#64
What this PR does / why we need it
Change
Completed
toComplete
because otherwise verify checks don't work 😞Special notes for your reviewer
If applicable**
What gif most accurately describes how I feel towards this PR?