Skip to content

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Jul 18, 2025

PR summary

including a missing example, renaming tags to match with method names

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pooraniss-ibm pooraniss-ibm requested a review from pyrooka July 18, 2025 10:06
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences-examples branch 2 times, most recently from e4e1aad to ae560e1 Compare July 18, 2025 12:08
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo to fix, otherwise it looks good. I approve it now to avoid the re-review, but please fix it @pooraniss-ibm.

}

try {
System.out.println("getPreferenceOnScopeAccount() result:");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
System.out.println("getPreferenceOnScopeAccount() result:");
System.out.println("getPreferencesOnScopeAccount() result:");

Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences-examples branch from ae560e1 to a73c17c Compare July 18, 2025 12:44
@pyrooka pyrooka changed the title fix(IAM Identity): missing exmaples for preferences fix(IAM Identity): add missing examples for preferences Jul 18, 2025
@pyrooka pyrooka merged commit 7166cc6 into main Jul 18, 2025
10 checks passed
@pyrooka pyrooka deleted the iam-identity-preferences-examples branch July 18, 2025 12:52
ibm-devx-sdk pushed a commit that referenced this pull request Jul 18, 2025
## [0.68.1](0.68.0...0.68.1) (2025-07-18)

### Bug Fixes

* **IAM Identity:** add missing examples for preferences ([#278](#278)) ([7166cc6](7166cc6))
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.68.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants