Skip to content

Conversation

Somchavan
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

===============================================
Default suite
Total tests run: 108, Passes: 108, Failures: 0, Skips: 0
===============================================

@Somchavan Somchavan force-pushed the iam-identity-link-del branch from e827846 to a683e60 Compare August 7, 2025 13:00
@Somchavan Somchavan requested a review from pyrooka August 7, 2025 13:08
@Somchavan Somchavan force-pushed the iam-identity-link-del branch from a683e60 to a96a746 Compare August 10, 2025 22:14
@pyrooka pyrooka changed the title fix(IAM Identity) add delete link with parameter api fix(IAM Identity): add delete link with parameter api Aug 11, 2025
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor code style related thing to fix, otherwise looks good. @Somchavan can I expect more PRs in the other language repos?


// Save the id for use by other test methods.
serviceIdGroupId = serviceIdGroupResult.getId();
serviceIdGroupName=serviceIdGroupResult.getName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
serviceIdGroupName=serviceIdGroupResult.getName();
serviceIdGroupName = serviceIdGroupResult.getName();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Signed-off-by: Somanath Chavan <somanath.chavan@ibm.com>
@Somchavan Somchavan force-pushed the iam-identity-link-del branch from a96a746 to e7613cf Compare August 12, 2025 09:31
@pyrooka pyrooka merged commit d76f5da into IBM:main Aug 12, 2025
6 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Aug 12, 2025
## [0.68.5](0.68.4...0.68.5) (2025-08-12)

### Bug Fixes

* **IAM Identity:** add delete link with parameter api ([#281](#281)) ([d76f5da](d76f5da))
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.68.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants