Reorganize transports under itoolkit.transport #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all transports a single package, mapped as such: itoolkit.lib.iLibCall -> itoolkit.transport.DirectTransport itoolkit.rest.iRestCall -> itoolkit.transport.HttpTransport itoolkit.db2.iDB2Call -> itoolkit.transport.DatabaseTransport The old modules are now deprecated, but kept for compatibility. They simply forward to the new module from the mapping above. The old names will be removed if there is a 2.0.0 release. All references to the old module names have been updated, except those in the deprecated modules themselves.
|
This PR fixes #1 by re-organizing the imports under a common sub-package. It also fixes #15 - you can use the itoolkit.transport.DatabaseTransport with any PEP-249 compliant database connection, eg. import pyodbc
from itoolkit.transport import DatabaseTransport
conn = pyodbc.connect("DSN=mydsn")
transport = DatabaseTransport(conn) |
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all transports a single package, mapped as such:
itoolkit.lib.iLibCall -> itoolkit.transport.DirectTransport
itoolkit.rest.iRestCall -> itoolkit.transport.HttpTransport
itoolkit.db2.iDB2Call -> itoolkit.transport.DatabaseTransport
The old modules are now deprecated, but kept for compatibility.
They simply forward to the new module from the mapping above. The
old names will be removed if there is a 2.0.0 release.
All references to the old module names have been updated, except
those in the deprecated modules themselves.