Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TLS options with client auth to kafka-console-producer and consumer #1300

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Added TLS options with client auth to kafka-console-producer and consumer #1300

merged 4 commits into from
Mar 6, 2019

Conversation

andrejvanderzee
Copy link
Contributor

For testing TLS with Kafka ACL I added TLS options for the consumer and producer tools...

@ghost ghost added the cla-needed label Mar 4, 2019
@andrejvanderzee
Copy link
Contributor Author

Signed CLA.

@ghost ghost removed the cla-needed label Mar 4, 2019
@andrejvanderzee andrejvanderzee changed the title Added TLS option with client auth to kafka-console-producer and consumer Added TLS options with client auth to kafka-console-producer and consumer Mar 4, 2019
@bai bai requested a review from varun06 March 5, 2019 07:51
varun06
varun06 reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@varun06 varun06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tls related parts are similar, I wonder if we can reuse them(have a tls.go in root of directory and then call them here and in consumer file).

varun06
varun06 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@varun06 varun06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bai
Copy link
Contributor

bai commented Mar 6, 2019

Thanks!

@bai bai merged commit cb940f0 into IBM:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varun06 varun06 varun06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrejvanderzee @bai @varun06