Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add String, (Un)MarshalText for acl types. #1541

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Conversation

izolight
Copy link
Contributor

Sometimes it's useful converting the constants of the acl types from/to text.
The text representation is the name without the prefix.
When converting from text to the types the string will be normalized to catch most variants.

acl_types.go Outdated Show resolved Hide resolved
@d1egoaz
Copy link
Contributor

d1egoaz commented Jan 21, 2020

@izolight it seems you'll need to update the map declaration mapping := map[AclOperation]string{

image

@dnwe
Copy link
Collaborator

dnwe commented Feb 21, 2020

@izolight hiya — just wondering if you think you'll have time to resume work on this PR?

@izolight
Copy link
Contributor Author

I updated it so that the pointers are now dereferenced in the function.

@ghost
Copy link

ghost commented Mar 16, 2021

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with master and rebase if needed. If you are awaiting a (re-)review then please let us know.

@ghost ghost added the stale Issues and pull requests without any recent activity label Mar 16, 2021
@ghost ghost removed the stale Issues and pull requests without any recent activity label Mar 18, 2021
Copy link
Contributor Author

@izolight izolight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased to the latest master an implemented the proposed changes.
Anything preventing this PR from getting merged now?

@bai
Copy link
Contributor

bai commented Mar 18, 2021

Thanks for contributing 🙏🏼

@bai bai merged commit 41df78d into IBM:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants