-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add String, (Un)MarshalText for acl types. #1541
Conversation
aa8b1ef
to
85ff7e2
Compare
@izolight it seems you'll need to update the |
@izolight hiya — just wondering if you think you'll have time to resume work on this PR? |
I updated it so that the pointers are now dereferenced in the function. |
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased to the latest master an implemented the proposed changes.
Anything preventing this PR from getting merged now?
Thanks for contributing 🙏🏼 |
Sometimes it's useful converting the constants of the acl types from/to text.
The text representation is the name without the prefix.
When converting from text to the types the string will be normalized to catch most variants.