Add DescribeLogDirs to admin client #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
force-pushed
the
admin-describelogdirs
branch
from
d2046e9
to
d89fa9d
Compare
Sjeanpierre
reviewed
Mar 28, 2020
| broker, err := ca.findBroker(b) | ||
| if err != nil { | ||
| Logger.Printf("Unable to find broker with ID = %v\n", b) | ||
| continue |
There was a problem hiding this comment.
In the case of a missing broker, will the waitgroup ever finish waiting since a done was never called at this point?
There was a problem hiding this comment.
In case a broker does not reply, it will block for config.Net.ReadTimeout and return with an error read tcp 127.0.0.1:60810->127.0.0.1:9092: i/o timeout.
The same happens in ListConsumerGroups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.