Bugfix: Allow TLS connections to work over socks proxy. #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@probot-shopify |
|
@github-actions CI / Go 1.13.x with Kafka 2.4.0 on Ubuntu (pull_request) hmmm seems like an intermittant problem exists ;) |
dnwe
approved these changes
May 5, 2020
@KevinJCross did you add the code for this? |
bai
added a commit
that referenced
this pull request
May 9, 2020
* master: testfix: set KAFKA_HEAP_OPTS for zk and kafka testfix: give kafka longer to startup Creates conf.Net.TLS.Config if not provided Set ServerName using tls.DialWithDialer approach Reduce build matrix fix: Allow TLS to work over socks proxy. (#1666) AdminClient Test Handle errors with no message Handle errors with no message Add a functional test to cover idempotent production Fix "broker received out of order sequence" when brokers die Add DescribeLogDirs to admin client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the code was either proxy or tls but in my case I need tls over the socks proxy so Ive created this PR to fix this issue.
Note there seems to be an issue with the tls test where the server name was never set so Ive fixed that too.