Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add private method to Client interface to prevent implementation" #1817

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Revert "Add private method to Client interface to prevent implementation" #1817

merged 1 commit into from
Oct 21, 2020

Conversation

d1egoaz
Copy link
Contributor

@d1egoaz d1egoaz commented Oct 21, 2020

Reverts #1785

this is causing more damage that the initial intention to prevent breaking changes.

Some people are using mock libraries and they are getting issues with this change

i.e, when using mockery

Cannot use 'mockSaramaClient' (type *mocks.Client) as type sarama.Client Type cannot implement 'sarama.Client' as it has a non-exported method and is defined in a different package

@d1egoaz d1egoaz requested a review from bai as a code owner October 21, 2020 19:34
@nayeemzen
Copy link

🚢

@d1egoaz d1egoaz merged commit d1d820a into master Oct 21, 2020
@d1egoaz d1egoaz deleted the revert-1785-client-interface-private branch October 21, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeemzen nayeemzen nayeemzen approved these changes

@bai bai Awaiting requested review from bai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d1egoaz @nayeemzen