KIP-392: Allow consumers to fetch from closest replica #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address comments on IBM#1696. Change to only adding and using a new preferredReadReplica field. Move setting of the preferredReadReplica field up in parseResponse. This causes the returned preferred read replica to be used even if there are no records in the fetch response. Set FetchResponse.PreferredReadReplica to -1 when decoding versions prior to 11. Add more tests. Change consumeMsgs in functional tests to use subtests to reduce number of outstanding connections.
ghost
added
the
|
I signed the CLA. |
dnwe
approved these changes
Nov 6, 2020
dnwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for KIP-392 in Sarama consumers.
This is a continuation of #1696 with changes mentioned here.
Co-authored-by: "Deepak.Neralla" Deepak.Neralla@mixpanel.com