Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test out CodeQL #1925

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Test out CodeQL #1925

merged 1 commit into from
Apr 28, 2021

Conversation

bai
Copy link
Contributor

@bai bai commented Apr 28, 2021

Ref: #1924

@bai bai requested a review from dnwe April 28, 2021 09:02
dnwe
dnwe approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dnwe
Copy link
Collaborator

dnwe commented Apr 28, 2021

So here are the initial findings that we would want to fix under this PR before merging and having master scanned:

https://github.com/Shopify/sarama/security/code-scanning?query=ref%3Arefs%2Fpull%2F1925%2Fmerge+tool%3ACodeQL

@bai bai merged commit 1c17804 into master Apr 28, 2021
@bai bai deleted the codeql branch April 28, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwe dnwe dnwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bai @dnwe