Use gofork for encoding/asn1 to fix ASN errors during Kerberos authentication #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ozzieba
force-pushed
the
revert-removing-of-fork-for-asn1
branch
from
243350c
to
b4b259d
Compare
dnwe
approved these changes
May 5, 2021
There was a problem hiding this comment.
LGTM, thanks for this. We should probably add a functional test that includes a kafka cluster configured for Kerberos to prevent this regressing again in the future. @ozzieba is that something you might be able to look at in a followup PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1932