Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using xdg-go module for SCRAM #2000

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Using xdg-go module for SCRAM #2000

merged 1 commit into from
Aug 31, 2021

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Aug 26, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

As per title, I am updating deprecated 'xdg/scram' to use the actual module 'xdg-go/scram'

See: https://github.com/xdg/scram/blob/v1.0.3/README.md

…ram'

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew requested a review from bai as a code owner August 26, 2021 18:23
@matzew
Copy link
Contributor Author

matzew commented Aug 31, 2021

/assign @dnwe
Do you mind taking a look here? The other lib is deprecated, hence moving forward w/ this - thanks!

@dnwe
Copy link
Collaborator

dnwe commented Aug 31, 2021

@matzew thanks for the contribution, much appreciated! The changes look good to me and all tests are passing so 👍

@dnwe dnwe merged commit 839d956 into IBM:master Aug 31, 2021
@dnwe dnwe changed the title Using xdg-go module for SCARM Using xdg-go module for SCRAM Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants