Expose the TLS connection state of a broker connection #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how net/smtp and others do this, this gives one access to tls state date without having to expose the underlying connection. This is useful for e.g. monitoring software.
ghost
added
the
|
I have now signed the CLA, but don't seem to be able to re-run the check. |
|
Thanks for contributing! This change looks good to me - thoughts @dnwe? |
dnwe
approved these changes
Jan 21, 2022
This was referenced Feb 1, 2022
This was referenced Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding kafka support to a piece of monitoring software that does protocol-level checks but also does tls verification beyond what net/tls does. For this to work the software needs access to the tls connection state. net/smtp and go-ldap expose this in the same way.