Add support for Castagnoli polynomial for CRC32 computation #971
Conversation
This is needed for Kafka 0.11 support as the new records' checksum is computed with Castagnoli polynomial (previous versions of Kafka use IEEE polynomial).
crc32_field.go
Outdated
| @@ -6,9 +6,17 @@ import ( | |||
| "hash/crc32" | |||
| ) | |||
|
|
|||
| const ( | |||
| crcIEEE = iota | |||
| crcCastagnoli | |||
There was a problem hiding this comment.
Why define these? you can just have newCRC32Field take the crc32-defined constant directly?
There was a problem hiding this comment.
Do you mean I should use the polynomial constants directly? I could, as they are just ints, but it didn't seem very clean to me as the intent here is to represent an enumeration of supported polynomials in the context of Kafka protocol, not the polynomial itself.
But if you feel strongly about it, I can remove them.
There was a problem hiding this comment.
That's what I meant, but I see your point. In that case it probably makes sense to explicitly type it (e.g. the way that compression codecs are) rather than using ints, since the polynomials themselves are just ints.
|
Looks like TravisCI is having infrastructure issues, but this is fine. Thanks! |
This is needed for Kafka 0.11 support as the new records' checksum is
computed with Castagnoli polynomial (previous versions of Kafka use
IEEE polynomial).
Issue #901