Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to github.com/IBM/go-sdk-core/v5. #30

Closed
wants to merge 1 commit into from
Closed

Conversation

JMGordon
Copy link

@JMGordon JMGordon commented Sep 2, 2022

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

After upgrading to github.com/IBM/go-sdk-core/v5 the tests were executed. Assuming the test suite is comprehensive then no breakages are anticipated since all tests passed.

* github.com/IBM/go-sdk-core/v4 v4.10.0 depends on github.com/dgrijalva/jwt-go-v3.2.0
  which contains vulnerability https://nvd.nist.gov/vuln/detail/CVE-2020-26160.

* IBM#25

Signed-off-by: Joseph Gordon <jmatthewgordon@us.ibm.com>
@JMGordon
Copy link
Author

JMGordon commented Sep 2, 2022

Closing to repon from another branch.

@JMGordon JMGordon closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant