Minor updates on Readme #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KipTwitchell <kip.twitchell@us.ibm.com>
najohnsn
reviewed
Aug 26, 2022
README.md
Outdated
| The basic syntax of the initial `goto` command is: | ||
|
|
||
| ``` | ||
| goto fully-qualified-host-name [port] |
There was a problem hiding this comment.
should be goto fully-qualified-host-name[:port]
README.md
Outdated
| @@ -57,6 +57,15 @@ Key tab for command completion, up/down for command history. | |||
| The `goto` command takes you to a full screen 3270 interface. When | |||
| space is available in the terminal screen/window, a status line is | |||
| provided as well as a session selector. | |||
|
|
|||
| The basic syntax of the initial `goto` command is: | |||
There was a problem hiding this comment.
"initial" doesn't matter. can you remove it?
README.md
Outdated
| goto fully-qualified-host-name [port] | ||
| ``` | ||
|
|
||
| If no port is specified, port 992, signifing to use TLS, is used. |
There was a problem hiding this comment.
Well... 992 will be the default if using the default SESSION_SSL=0. Setting SESSION_SSL=1 will make the default port 23. Maybe stating this is too complicated for the README?
Signed-off-by: KipTwitchell <kip.twitchell@us.ibm.com>
Signed-off-by: KipTwitchell <kip.twitchell@us.ibm.com>
najohnsn
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KipTwitchell kip.twitchell@us.ibm.com