Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix tolerations setting in flex daemonset to support also ICP v2.1.0.2+ #203

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

shay-berman
Copy link
Contributor

@shay-berman shay-berman commented Jul 22, 2018

Installing Ubiqutiy in ICP 2.1.0.2+ is failing because the daemonset tolerations setting is not working well on ICP v 2.1.0.2+.
the ICP master nodes (BTW on vanila k8s the current tolerations as ok).
Matthew Levan found that the current tolerations setting in the flex daemonset are not working on ICP 2.1.0.2+ and its not installing flex on the master nodes at all (only on the worker nodes which is not enough).

Here is the current daemonset toleration setting:

      tolerations:  
      - key: dedicated
        operator: Equal
        value: master
        effect: NoSchedule

In order to make it works also on ICP 2.1.0.2+ (and also vanilla k8s) here is fixed setting:

      tolerations:  
      - key: dedicated
        operator: Exists
        effect: NoSchedule

Note: internal ticket UB-1009


This change is Reviewable

@shay-berman shay-berman self-assigned this Jul 22, 2018
@shay-berman shay-berman changed the title Fix tolerations flex-daemonset.yml to operator:Exists for ICP 2.1.0.2… Fix tolerations setting in flex daemonset to support also ICP v2.1.0.2+ Jul 22, 2018
@shay-berman shay-berman requested a review from alonm July 22, 2018 18:33
@shay-berman
Copy link
Contributor Author

This fix passed CI sanity and extended on vanilla k8s 1.8.

@matt-levan
Copy link

matt-levan commented Jul 23, 2018

:lgtm:

@shay-berman shay-berman requested review from matt-levan and removed request for alonm July 23, 2018 14:35
@shay-berman
Copy link
Contributor Author

also passed sanity on k8s 1.7 in CI

Copy link

@matt-levan matt-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@shay-berman shay-berman merged commit ec3882d into dev Jul 24, 2018
@shay-berman shay-berman deleted the fix/flex-daemonset-fix-for-icp2.1.0.2 branch September 17, 2018 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants