Fix/ub 1550 fix provisioner error message #259
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
(please make sure the text is ok with Dima)
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @shay-berman and @olgashtivelman)
volume/provision.go, line 102 at r2 (raw file):
if isTimeOutError(err) { // The log is here to advise the user on where to look for further information logger.Printf("Failed to start ubiqutiy-k8s-provisioner due to connectivity issue to ubiqutiy pod")
please check text with Dima (btw i think you missed dot at the end of the sentence.)
volume/provision.go, line 109 at r2 (raw file):
} func isTimeOutError(err error) bool {
if its easy to add 1 UT for this function go for it, but if not its ok since its very basic.
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @shay-berman and @olgashtivelman)
volume/provision.go, line 109 at r2 (raw file):
Previously, shay-berman wrote…
if its easy to add 1 UT for this function go for it, but if not its ok since its very basic.
it is not easy unfortunately (I will need to re-create the error) . so i skipped it since its also just for the log message and no actual logic.
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @shay-berman and @olgashtivelman)
volume/provision.go, line 102 at r2 (raw file):
Previously, shay-berman wrote…
please check text with Dima (btw i think you missed dot at the end of the sentence.)
Done.
change error: "panic: Error starting ubiquity client" to "panic: Error starting ubiquity provisioner"
This change is