-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removal of dpath -- ready for review #680
Conversation
b4a4346
to
3dc65c9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 89.83% 89.95% +0.11%
==========================================
Files 96 96
Lines 9201 9419 +218
==========================================
+ Hits 8266 8473 +207
- Misses 935 946 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
@elronbandel , @yoavkatz , I suggest to remove the boolean parameter Other than enjoying to play with it in the testing, I do not see any real value for this Again: the meaning thereof is clear if * comes at the end, but the same result is achievable by assigning the whole vector as one unit, to the parent of the * in the query. The meaning thereof for * in the middle of the query was guessed by myself, and thus implemented.. You may see some examples in I wrote extended docstring for dict_set. Please see if this looks clear enough. |
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing Dafna! I think any comments on top of this implementation should be in a seperate PR as this one defentily satisfy its original goal! well done!
* first draft for removal of dpath Signed-off-by: dafnapension <dafnashein@yahoo.com> * simpler home-made dpath Signed-off-by: dafnapension <dafnashein@yahoo.com> * some fixes Signed-off-by: dafnapension <dafnashein@yahoo.com> * start code coverage Signed-off-by: dafnapension <dafnashein@yahoo.com> * extend code coverage Signed-off-by: dafnapension <dafnashein@yahoo.com> * allow spaces in instance keys Signed-off-by: dafnapension <dafnashein@yahoo.com> * remove dpath from requirement and expand code coverage Signed-off-by: dafnapension <dafnashein@yahoo.com> * cover a few lines of code more Signed-off-by: dafnapension <dafnashein@yahoo.com> * cover some more lines of code Signed-off-by: dafnapension <dafnashein@yahoo.com> * EncodeLabel is back to instance rather than field operator. Signed-off-by: dafnapension <dafnashein@yahoo.com> * live with set_multiple, and avoid premature end of recursive scan Signed-off-by: dafnapension <dafnashein@yahoo.com> * cover some more Signed-off-by: dafnapension <dafnashein@yahoo.com> * cover more yet again Signed-off-by: dafnapension <dafnashein@yahoo.com> --------- Signed-off-by: dafnapension <dafnashein@yahoo.com>
Hi Elron and Yoav,
d_path is out of dict_utility, and of both requirement files where it showed.
I also cancelled the ban of
process_every_value
not allowed for operatorRemoveValues
(a ban laid only on it..)We do need
process_every_value
here.Speaking of which (the family of field operators, including all the postprocessors, that process a (single) prediction and
process every value
of list of references), why isEncodeLabels
so much of an outsider?There is a straightforward implementation thereof as a field operator. Why was not it used?