-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added loader from HF spaces #860
Conversation
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 92.06% 91.56% -0.51%
==========================================
Files 104 104
Lines 10738 10977 +239
==========================================
+ Hits 9886 10051 +165
- Misses 852 926 +74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good. One request regarding token in the API.
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Can you make sure it works like other loaders with loader_limit? If its too complicated we can discuss leaving it aside for now
Signed-off-by: Paweł Knes <pawel.knes@ibm.com>
I made the loader inherit from LoadHF since the only difference is that it needs to download the data first, and then it operates on HF dataset as well |
Added a possibility to load data from Huggingface spaces as per #857