Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/relation extractor evaluation #39

Merged
merged 14 commits into from
Dec 7, 2022

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Dec 1, 2022

Status Type ⚠️ Core Change Issue
Ready Bug No

Problem

  • Possible overflow error and relation evaluation issue
  • FewRel was not returning a Dataset object

Solution

  • Fixed possible overflow error and relation evaluation
  • Refactor the RE pipeline

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 92.18% // Head: 92.20% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c078a98) compared to base (2a84de0).
Patch coverage: 91.66% of modified lines in pull request are covered.

❗ Current head c078a98 differs from pull request most recent head 9742e6e. Consider uploading reports for the commit 9742e6e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   92.18%   92.20%   +0.02%     
==========================================
  Files          67       67              
  Lines        2763     2758       -5     
==========================================
- Hits         2547     2543       -4     
+ Misses        216      215       -1     
Impacted Files Coverage Δ
...hot/relation_extractor/zsrc/zero_shot_rel_class.py 78.89% <0.00%> (-0.74%) ⬇️
zshot/evaluation/dataset/fewrel/fewrel.py 96.96% <100.00%> (+4.11%) ⬆️
...ot/evaluation/dataset/med_mentions/med_mentions.py 100.00% <100.00%> (ø)
zshot/evaluation/pipeline.py 100.00% <100.00%> (ø)
zshot/linker/linker_smxm.py 96.77% <100.00%> (+0.10%) ⬆️
...shot/mentions_extractor/mentions_extractor_smxm.py 100.00% <100.00%> (ø)
zshot/tests/evaluation/test_datasets.py 100.00% <100.00%> (ø)
zshot/tests/evaluation/test_evaluation.py 99.46% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GabrielePicco GabrielePicco merged commit 29f69d4 into main Dec 7, 2022
@GabrielePicco GabrielePicco deleted the fix/relation-extractor-evaluation branch December 7, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant