🐛 Fixed TypeError when printing DatasetWithEntities #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.58% // Head: 80.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 49 49
Lines 1772 1772
=======================================
Hits 1428 1428
Misses 344 344
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg
force-pushed
the
bug/print-dataset
branch
from
e629adc
to
9adc64c
Compare
GabrielePicco
approved these changes
Sep 28, 2022
GabrielePicco
added a commit
that referenced
this pull request
Oct 28, 2022
* 🎉 First commit * 👷 Build pages doc * 🎉 First commit * ✏️ Fix repo links * 👷 Publish to pypi on release * 📝 Update Readme.md * 📝 Update Readme.md * 👷 Update pypi info * 👷 Add manual deploy * 📄 Version tag * 📄 Update version tag * 📄 Add pypi long description * ✏️ Fix typo * 🎨 Improve doc for pypi * 📝 Update index * Delete graph.png * 💫 Update logo * ✅ Add python tests * ⚡ [ImgBot] Optimize images (#1) *Total -- 392.70kb -> 298.54kb (23.98%) /docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%) /docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%) /docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%) /docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * 👷 Update python tests * 📝 Update README.md * 📝 Update index.md * ✅ Add codescan action * ✅ Add code coverage * 📝 Update Readme.md * 📝 Update Readme.md * 🐛 Fixed TypeError when printing DatasetWithEntities (#4) Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix displacy render function (#10) * 🐛 Fix displacy render Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Add displacy test Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * 🔖 v0.0.2 * 📝 Update Readme.md (#13) Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Evaluation tests improvement (#5) * ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests * 👷 Add action cache * 🩹 Remove cache after tests passed * 🔨 Updated load_medmentions to load from hub * 🗃️ Use org medmentionsZS Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * 📝 Update logo * ♻️ Remove unused code & host Smxm model on HG hub (#14) * ♻️ Remove unused code Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Add CI cache Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Update codecov action Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Download smxm from the hugginface hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Use models from IBM org on HG hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ⚡ Improve coverage Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 🎨 Fix code style Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ➖ delete unused file * Feat/zshot version (#17) * 🎨 Improved structure of setup and init. * ✏️ Fixed minor typos and format in evaluator * ✅ Update evaluation tests to work with latest version of evaluate * 🐛 Fixed bug while importing version * 🎨 Add RE visualization * 🎨 Fix styling * 🐛 Fix spans conversion to Spacy ent (#20) * 🐛 Fix pipeline setup * 🐛 Fix alignment * 🐛 Fix import * 🎨 Code style * 🐛 Remove appdata * 🐛 Fix displacy test Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>
GabrielePicco
pushed a commit
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
GabrielePicco
added a commit
that referenced
this pull request
Oct 28, 2022
* 🎉 First commit * 👷 Build pages doc * 🎉 First commit * ✏️ Fix repo links * 👷 Publish to pypi on release * 📝 Update Readme.md * 📝 Update Readme.md * 👷 Update pypi info * 👷 Add manual deploy * 📄 Version tag * 📄 Update version tag * 📄 Add pypi long description * ✏️ Fix typo * 🎨 Improve doc for pypi * 📝 Update index * Delete graph.png * 💫 Update logo * ✅ Add python tests * ⚡ [ImgBot] Optimize images (#1) *Total -- 392.70kb -> 298.54kb (23.98%) /docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%) /docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%) /docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%) /docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * 👷 Update python tests * 📝 Update README.md * 📝 Update index.md * ✅ Add codescan action * ✅ Add code coverage * 📝 Update Readme.md * 📝 Update Readme.md * 🐛 Fixed TypeError when printing DatasetWithEntities (#4) Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix displacy render function (#10) * 🐛 Fix displacy render Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Add displacy test Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * 🔖 v0.0.2 * 📝 Update Readme.md (#13) Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Evaluation tests improvement (#5) * ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests * 👷 Add action cache * 🩹 Remove cache after tests passed * 🔨 Updated load_medmentions to load from hub * 🗃️ Use org medmentionsZS Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * 📝 Update logo * ♻️ Remove unused code & host Smxm model on HG hub (#14) * ♻️ Remove unused code Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Add CI cache Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Update codecov action Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Download smxm from the hugginface hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Use models from IBM org on HG hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ⚡ Improve coverage Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 🎨 Fix code style Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ➖ delete unused file * Feat/zshot version (#17) * 🎨 Improved structure of setup and init. * ✏️ Fixed minor typos and format in evaluator * ✅ Update evaluation tests to work with latest version of evaluate * 🐛 Fixed bug while importing version * 🎨 Add RE visualization * 🎨 Fix styling * 🐛 Fix spans conversion to Spacy ent (#20) * 🐛 Fix pipeline setup * 🐛 Fix alignment * 🐛 Fix import * 🎨 Code style * 🐛 Remove appdata * 🐛 Fix displacy test Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TypeErrorraises when printing a DatasetWithEntities. See #3Solution
Access the name of the entity instead of treating it like a
dictCloses #3