♻️ Remove unused code #14

GabrielePicco · 2022-10-11T13:41:05Z

Code refactoring and moving model to HG hub

Status	Type	⚠️ Core Change	Issue
Ready	Refactor	No	#8

Problem

Unused code and some model hosted on BOX

Solution

Refactoring the code and moving model weight to HG hub

Issues

Closes #8

codecov · 2022-10-12T15:12:47Z

Codecov Report

Base: 81.40% // Head: 90.85% // Increases project coverage by +9.45% 🎉

Coverage data is based on head (89b0412) compared to base (32798cf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   81.40%   90.85%   +9.45%     
==========================================
  Files          49       48       -1     
  Lines        1785     1727      -58     
==========================================
+ Hits         1453     1569     +116     
+ Misses        332      158     -174

Impacted Files	Coverage Δ
zshot/config.py	`100.00% <ø> (ø)`
...ot/evaluation/dataset/med_mentions/med_mentions.py	`100.00% <100.00%> (+57.89%)`	⬆️
zshot/linker/linker_regen/linker_regen.py	`100.00% <100.00%> (ø)`
zshot/linker/linker_smxm.py	`97.77% <100.00%> (-0.05%)`	⬇️
zshot/linker/smxm/data.py	`98.66% <100.00%> (ø)`
zshot/linker/smxm/utils.py	`100.00% <100.00%> (ø)`
zshot/pipeline_config.py	`100.00% <100.00%> (ø)`
zshot/tests/evaluation/test_datasets.py	`100.00% <100.00%> (ø)`
zshot/tests/evaluation/test_evaluation.py	`100.00% <100.00%> (ø)`
zshot/tests/linker/test_regen_linker.py	`100.00% <100.00%> (ø)`
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 🎉 First commit * 👷 Build pages doc * 🎉 First commit * ✏️ Fix repo links * 👷 Publish to pypi on release * 📝 Update Readme.md * 📝 Update Readme.md * 👷 Update pypi info * 👷 Add manual deploy * 📄 Version tag * 📄 Update version tag * 📄 Add pypi long description * ✏️ Fix typo * 🎨 Improve doc for pypi * 📝 Update index * Delete graph.png * 💫 Update logo * ✅ Add python tests * ⚡ [ImgBot] Optimize images (#1) *Total -- 392.70kb -> 298.54kb (23.98%) /docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%) /docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%) /docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%) /docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * 👷 Update python tests * 📝 Update README.md * 📝 Update index.md * ✅ Add codescan action * ✅ Add code coverage * 📝 Update Readme.md * 📝 Update Readme.md * 🐛 Fixed TypeError when printing DatasetWithEntities (#4) Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix displacy render function (#10) * 🐛 Fix displacy render Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Add displacy test Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * 🔖 v0.0.2 * 📝 Update Readme.md (#13) Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Evaluation tests improvement (#5) * ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests * 👷 Add action cache * 🩹 Remove cache after tests passed * 🔨 Updated load_medmentions to load from hub * 🗃️ Use org medmentionsZS Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * 📝 Update logo * ♻️ Remove unused code & host Smxm model on HG hub (#14) * ♻️ Remove unused code Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Add CI cache Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Update codecov action Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Download smxm from the hugginface hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Use models from IBM org on HG hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ⚡ Improve coverage Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 🎨 Fix code style Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ➖ delete unused file * Feat/zshot version (#17) * 🎨 Improved structure of setup and init. * ✏️ Fixed minor typos and format in evaluator * ✅ Update evaluation tests to work with latest version of evaluate * 🐛 Fixed bug while importing version * 🎨 Add RE visualization * 🎨 Fix styling * 🐛 Fix spans conversion to Spacy ent (#20) * 🐛 Fix pipeline setup * 🐛 Fix alignment * 🐛 Fix import * 🎨 Code style * 🐛 Remove appdata * 🐛 Fix displacy test Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>

* ♻️ Remove unused code Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Add CI cache Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Update codecov action Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Download smxm from the hugginface hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Use models from IBM org on HG hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ⚡ Improve coverage Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 🎨 Fix code style Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* 🎉 First commit * 👷 Build pages doc * 🎉 First commit * ✏️ Fix repo links * 👷 Publish to pypi on release * 📝 Update Readme.md * 📝 Update Readme.md * 👷 Update pypi info * 👷 Add manual deploy * 📄 Version tag * 📄 Update version tag * 📄 Add pypi long description * ✏️ Fix typo * 🎨 Improve doc for pypi * 📝 Update index * Delete graph.png * 💫 Update logo * ✅ Add python tests * ⚡ [ImgBot] Optimize images (#1) *Total -- 392.70kb -> 298.54kb (23.98%) /docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%) /docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%) /docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%) /docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * 👷 Update python tests * 📝 Update README.md * 📝 Update index.md * ✅ Add codescan action * ✅ Add code coverage * 📝 Update Readme.md * 📝 Update Readme.md * 🐛 Fixed TypeError when printing DatasetWithEntities (#4) Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix displacy render function (#10) * 🐛 Fix displacy render Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Add displacy test Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * 🔖 v0.0.2 * 📝 Update Readme.md (#13) Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ✅ Evaluation tests improvement (#5) * ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests * 👷 Add action cache * 🩹 Remove cache after tests passed * 🔨 Updated load_medmentions to load from hub * 🗃️ Use org medmentionsZS Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> * 📝 Update logo * ♻️ Remove unused code & host Smxm model on HG hub (#14) * ♻️ Remove unused code Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Add CI cache Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 👷 Update codecov action Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Download smxm from the hugginface hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ♻️ Use models from IBM org on HG hub Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * ⚡ Improve coverage Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> * 🎨 Fix code style Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> * ➖ delete unused file * Feat/zshot version (#17) * 🎨 Improved structure of setup and init. * ✏️ Fixed minor typos and format in evaluator * ✅ Update evaluation tests to work with latest version of evaluate * 🐛 Fixed bug while importing version * 🎨 Add RE visualization * 🎨 Fix styling * 🐛 Fix spans conversion to Spacy ent (#20) * 🐛 Fix pipeline setup * 🐛 Fix alignment * 🐛 Fix import * 🎨 Code style * 🐛 Remove appdata * 🐛 Fix displacy test Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm> Co-authored-by: Gabriele Picco <piccogabriele@gmail.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>

GabrielePicco force-pushed the enhance/code-refactor branch 3 times, most recently from a6ac96d to d492646 Compare October 12, 2022 14:50

GabrielePicco force-pushed the enhance/code-refactor branch from dab71ed to bed746e Compare October 12, 2022 15:17

Gabriele Picco and others added 6 commits October 12, 2022 17:03

♻️ Remove unused code

0c09de7

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm> Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

👷 Add CI cache

7d51763

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

👷 Update codecov action

47e295a

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

♻️ Download smxm from the hugginface hub

c1a59d5

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

♻️ Use models from IBM org on HG hub

70631e0

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

⚡ Improve coverage

6f5bc5a

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

GabrielePicco force-pushed the enhance/code-refactor branch from 137812a to 6f5bc5a Compare October 12, 2022 16:04

🎨 Fix code style

89b0412

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

GabrielePicco merged commit c44156d into main Oct 12, 2022

GabrielePicco deleted the enhance/code-refactor branch October 12, 2022 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

♻️ Remove unused code #14

♻️ Remove unused code #14

GabrielePicco commented Oct 11, 2022 •

edited

Loading

codecov bot commented Oct 12, 2022 •

edited

Loading

♻️ Remove unused code #14

♻️ Remove unused code #14

Conversation

GabrielePicco commented Oct 11, 2022 • edited Loading

Code refactoring and moving model to HG hub

Problem

Solution

Issues

codecov bot commented Oct 12, 2022 • edited Loading

Codecov Report

GabrielePicco commented Oct 11, 2022 •

edited

Loading

codecov bot commented Oct 12, 2022 •

edited

Loading