Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Evaluation tests improvement #5

Merged
merged 7 commits into from
Oct 7, 2022
Merged

✅ Evaluation tests improvement #5

merged 7 commits into from
Oct 7, 2022

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Sep 28, 2022

Status Type ⚠️ Core Change Issue
Ready Improvement No

Added tests for datasets:
load_ontonotes()
load_medmentions()

Added tests for MentionsExtractorPipeline and MentionsExtractorEvaluator

@GabrielePicco GabrielePicco mentioned this pull request Oct 6, 2022
Closed
GabrielePicco
GabrielePicco approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marmg and others added 7 commits October 7, 2022 08:36
@marmg
✅ Added datasets tests. Added Mentions extractor pipeline and evaluat…
8d8f82a 
…or tests

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@GabrielePicco
👷 Add action cache
c78a403 
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@GabrielePicco
👷 Add key param to cache action
4286ed7 
Add key param to cache action

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
🩹 Remove cache after tests passed
27b50ce 
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@marmg
🩹 Removed cache after test_dataset tests passed
108be35 
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@marmg
🔨 Updated load_medmentions to load from hub
4680eb5 
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@GabrielePicco
🗃️ Use org medmentionsZS
8192871 
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
@marmg marmg merged commit 2ccb24a into main Oct 7, 2022
@GabrielePicco GabrielePicco deleted the feat/improve-codecov branch October 7, 2022 10:54
GabrielePicco pushed a commit that referenced this pull request Oct 28, 2022
Add blink linker and flair mentions extractor (#5)
1e2f0b4 
* Add Blink linker

* Add Flair mention detector
GabrielePicco added a commit that referenced this pull request Oct 28, 2022
@GabrielePicco @imgbot
@ImgBotApp @marmg
Add RE visualization (#50)
0d10fd4 
* 🎉 First commit

* 👷 Build pages doc

* 🎉 First commit

* ✏️ Fix repo links

* 👷 Publish to pypi on release

* 📝 Update Readme.md

* 📝 Update Readme.md

* 👷 Update pypi info

* 👷 Add manual deploy

* 📄 Version tag

* 📄 Update version tag

* 📄 Add pypi long description

* ✏️ Fix typo

* 🎨 Improve doc for pypi

* 📝 Update index

* Delete graph.png

* 💫 Update logo

* ✅ Add python tests

* ⚡ [ImgBot] Optimize images (#1)

*Total -- 392.70kb -> 298.54kb (23.98%)

/docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%)
/docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%)
/docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%)
/docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>

* 👷 Update python tests

* 📝 Update README.md

* 📝 Update index.md

* ✅ Add codescan action

* ✅ Add code coverage

* 📝 Update Readme.md

* 📝 Update Readme.md

* 🐛 Fixed TypeError when printing DatasetWithEntities (#4)

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>

* 🐛 Fix displacy render function (#10)

* 🐛 Fix displacy render

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ✅ Add displacy test

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* 🔖 v0.0.2

* 📝 Update Readme.md (#13)

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ✅ Evaluation tests improvement (#5)

* ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests
* 👷 Add action cache
* 🩹 Remove cache after tests passed
* 🔨 Updated load_medmentions to load from hub
* 🗃️ Use org medmentionsZS

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

* 📝 Update logo

* ♻️ Remove unused code & host Smxm model on HG hub (#14)

* ♻️ Remove unused code

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 👷 Add CI cache

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 👷 Update codecov action

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ♻️ Download smxm from the hugginface hub

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ♻️ Use models from IBM org on HG hub

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ⚡ Improve coverage

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 🎨 Fix code style

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ➖ delete unused file

* Feat/zshot version (#17)

* 🎨 Improved structure of setup and init.
* ✏️ Fixed minor typos and format in evaluator
* ✅ Update evaluation tests to work with latest version of evaluate
* 🐛 Fixed bug while importing version

* 🎨 Add RE visualization

* 🎨 Fix styling

* 🐛 Fix spans conversion to Spacy ent (#20)

* 🐛 Fix pipeline setup

* 🐛 Fix alignment

* 🐛 Fix import

* 🎨 Code style

* 🐛 Remove appdata

* 🐛 Fix displacy test

Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <piccogabriele@gmail.com>
Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>
GabrielePicco pushed a commit that referenced this pull request Oct 28, 2022
Add blink linker and flair mentions extractor (#5)
52bb5b0 
* Add Blink linker

* Add Flair mention detector
GabrielePicco pushed a commit that referenced this pull request Oct 28, 2022
@marmg
✅ Evaluation tests improvement (#5)
767d5bf 
* ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests
* 👷 Add action cache
* 🩹 Remove cache after tests passed
* 🔨 Updated load_medmentions to load from hub
* 🗃️ Use org medmentionsZS

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
GabrielePicco added a commit that referenced this pull request Oct 28, 2022
@GabrielePicco @imgbot
@ImgBotApp @marmg
Add RE visualization (#50)
4284a90 
* 🎉 First commit

* 👷 Build pages doc

* 🎉 First commit

* ✏️ Fix repo links

* 👷 Publish to pypi on release

* 📝 Update Readme.md

* 📝 Update Readme.md

* 👷 Update pypi info

* 👷 Add manual deploy

* 📄 Version tag

* 📄 Update version tag

* 📄 Add pypi long description

* ✏️ Fix typo

* 🎨 Improve doc for pypi

* 📝 Update index

* Delete graph.png

* 💫 Update logo

* ✅ Add python tests

* ⚡ [ImgBot] Optimize images (#1)

*Total -- 392.70kb -> 298.54kb (23.98%)

/docs/img/annotations.png -- 79.47kb -> 49.25kb (38.03%)
/docs/img/graph.png -- 4.94kb -> 3.10kb (37.11%)
/docs/img/zshot-header.png -- 243.67kb -> 193.55kb (20.57%)
/docs/img/blink.png -- 64.62kb -> 52.64kb (18.54%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>

* 👷 Update python tests

* 📝 Update README.md

* 📝 Update index.md

* ✅ Add codescan action

* ✅ Add code coverage

* 📝 Update Readme.md

* 📝 Update Readme.md

* 🐛 Fixed TypeError when printing DatasetWithEntities (#4)

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>

* 🐛 Fix displacy render function (#10)

* 🐛 Fix displacy render

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ✅ Add displacy test

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* 🔖 v0.0.2

* 📝 Update Readme.md (#13)

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ✅ Evaluation tests improvement (#5)

* ✅ Added datasets tests. Added Mentions extractor pipeline and evaluator tests
* 👷 Add action cache
* 🩹 Remove cache after tests passed
* 🔨 Updated load_medmentions to load from hub
* 🗃️ Use org medmentionsZS

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>

* 📝 Update logo

* ♻️ Remove unused code & host Smxm model on HG hub (#14)

* ♻️ Remove unused code

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 👷 Add CI cache

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 👷 Update codecov action

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ♻️ Download smxm from the hugginface hub

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ♻️ Use models from IBM org on HG hub

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* ⚡ Improve coverage

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

* 🎨 Fix code style

Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>

Signed-off-by: Gabriele Picco <gabriele.picco@ibm.comm>
Signed-off-by: Gabriele Picco <piccogabriele@gmail.com>
Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>

* ➖ delete unused file

* Feat/zshot version (#17)

* 🎨 Improved structure of setup and init.
* ✏️ Fixed minor typos and format in evaluator
* ✅ Update evaluation tests to work with latest version of evaluate
* 🐛 Fixed bug while importing version

* 🎨 Add RE visualization

* 🎨 Fix styling

* 🐛 Fix spans conversion to Spacy ent (#20)

* 🐛 Fix pipeline setup

* 🐛 Fix alignment

* 🐛 Fix import

* 🎨 Code style

* 🐛 Remove appdata

* 🐛 Fix displacy test

Co-authored-by: Gabriele Picco <gabriele.picco@ibm.comm>
Co-authored-by: Gabriele Picco <piccogabriele@gmail.com>
Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Marcos Martinez <marcosmartinezgalindo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielePicco GabrielePicco GabrielePicco approved these changes

Assignees

@marmg marmg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marmg @GabrielePicco