Fix/tests #66
Merged
Fix/tests #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
This reverts commit eae7c8c. Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg
added a commit
that referenced
this pull request
Sep 5, 2023
* ✅🐛 Improve tests performance. Fix minor bugs related Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added download models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🎨 Fixed flake Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🎨 Fixed flake Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Added try/except on load models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Added try/except on load models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added xfail to tars tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Updated pydantic requirements Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added fewrel tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Updated tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Revert "✅ Updated tests" This reverts commit eae7c8c. Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> --------- Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg
added a commit
that referenced
this pull request
Sep 5, 2023
* ✨ Added KnowledgeExtractor. Added KnowGL Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Created tests for KnowledgeExtractor Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 📝 Added documentation of Knowledge Extractor component Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ♻️ Created mappings module from spans_to_ functions of Regen Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix bug in labels in KnowGL Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 📝 Updated README Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🎨 Fix flake Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 📝 Change test name Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🐛 Fix bug in relations renderer (#65) Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Fix/tests (#66) * ✅🐛 Improve tests performance. Fix minor bugs related Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added download models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🎨 Fixed flake Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * 🎨 Fixed flake Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Added try/except on load models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Added try/except on load models Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added xfail to tars tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Updated pydantic requirements Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Added fewrel tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * ✅ Updated tests Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> * Revert "✅ Updated tests" This reverts commit eae7c8c. Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> --------- Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com> --------- Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GitHub actions are being cancelled.
Solution
download_modelsstep to cache the models