Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help content for the rule input_onchange_review #1929

Closed
shunguoy opened this issue Jun 11, 2024 · 5 comments · Fixed by #1928
Closed

Update help content for the rule input_onchange_review #1929

shunguoy opened this issue Jun 11, 2024 · 5 comments · Fixed by #1928

Comments

@shunguoy
Copy link
Contributor

see the rule issue #1624
see the rule discussion result: https://ibm.ent.box.com/notes/1552679742378

@shunguoy
Copy link
Contributor Author

branch: dev-1624
PP: #1928

@philljenkins
Copy link
Contributor

implementing Help changes per the rule discussion: https://ibm.ent.box.com/notes/1552679742378

@philljenkins
Copy link
Contributor

philljenkins commented Jun 18, 2024

Previous rule messages were:

input_onchange_review: Verify that any changes of context are explained in advance to the user
Needs review

after implementation rule messages are:

input_onchange_review: Users must be advised if, due to a change of element value, a form automatically submits, a new window opens, or a change in focus occurs
Needs review

@philljenkins
Copy link
Contributor

philljenkins commented Jun 19, 2024

Help changes made per rule discussion note:

Before:

Screenshot 2024-06-19 at 10 23 31 AM

After:

Screenshot 2024-06-19 at 3 42 11 PM

@philljenkins
Copy link
Contributor

@shunguoy can you review the Help changes for technical accuracy, then we can move the PR to Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants