Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action carrying out a consistency check #114

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Add github action carrying out a consistency check #114

merged 1 commit into from
Aug 10, 2024

Conversation

williamsonrichard
Copy link
Contributor

No description provided.

@williamsonrichard
Copy link
Contributor Author

williamsonrichard commented Aug 5, 2024

@florenceclavaud This PR adds a 'github action' which will trigger whenever a branch is pushed or a pull request made, and will check the consistency of the ontology (and before that, check that it parses!). You can see below under 'All checks failed' that the consistency check failed in this case, as it should do. Once we fix the consistency of the ontology, it should pass (there will also be a little green/red/orange dot on the master branch once this PR is merged, which should become green when the ontology is consistent). Clicking on 'Details' (or clicking on the dot once the PR is merged/looking at the 'Actions' tab) and looking at the output, you should see a message about the ontology being inconsistent.

I have not attempted to configure it to provide any explanation about why there is an inconsistency, as I think it is enough here just to know that it is inconsistent; figuring out why can be done elsewhere.

If we wish in the future, it is also possible to configure github to e.g. prevent merging a PR into master if the consistency check triggered by the PR fails.

@florenceclavaud
Copy link
Contributor

This is a good idea; at least it will prevent us from forgetting to run Pellet or HermiT reasoners using Protégé or the command line when preparing a new version and release (which happened to me last time...).
Parsing can be done easily but of course it is a prerequisite. And of course there are a lot of other aspects that must be checked and that I check before releasing, but conformance to OWL DL is a very important feature.
Maybe you could comment the .py file just to specify that it will run HermiT OWL DL reasoner?

@williamsonrichard
Copy link
Contributor Author

williamsonrichard commented Aug 6, 2024

Done now :-)!

Copy link
Contributor

@florenceclavaud florenceclavaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, and I think this PR can be merged into the master branch directly :-). This will produce a 'check fail' about the master branch, which will remain there till I have completed the next-version and merged into the master. But it does not matter after all

@florenceclavaud florenceclavaud added this to the RiC-O 1.0.2 milestone Aug 9, 2024
@williamsonrichard williamsonrichard merged commit 211997f into ICA-EGAD:master Aug 10, 2024
1 check failed
@williamsonrichard williamsonrichard deleted the add_consistency_check_github_action branch August 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants