Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References #348

Merged
merged 14 commits into from
Sep 30, 2020
Merged

References #348

merged 14 commits into from
Sep 30, 2020

Conversation

elbaraim
Copy link
Member

added reference list using pyABC

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #348 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    83.59%   83.55%   -0.04%     
===========================================
  Files           87       87              
  Lines         5017     5017              
===========================================
- Hits          4194     4192       -2     
- Misses         823      825       +2     
Impacted Files Coverage Δ
pyabc/sampler/mapping.py 94.87% <0.00%> (-2.57%) ⬇️
pyabc/inference/util.py 96.96% <0.00%> (-1.02%) ⬇️
pyabc/weighted_statistics.py 91.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708a1a3...9f077b1. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to this from the documentation? Maybe in https://github.com/ICB-DCM/pyABC/blob/master/doc/index.rst just add under "about.rst".

references.rst Outdated
References
==========

List of publications using pyABC, total amounting to 28 citations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number needs to be updated (should be 16 if I can count).

references.rst Outdated Show resolved Hide resolved
Elba Raimúndez Alvarez and others added 2 commits September 28, 2020 12:54
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@elbaraim
Copy link
Member Author

Can you link to this from the documentation? Maybe in https://github.com/ICB-DCM/pyABC/blob/master/doc/index.rst just add under "about.rst".

i do not understand what you mean, do not know how to properly include it

@yannikschaelte
Copy link
Member

Can you link to this from the documentation? Maybe in https://github.com/ICB-DCM/pyABC/blob/master/doc/index.rst just add under "about.rst".

i do not understand what you mean, do not know how to properly include it

@elbaraim I added it now (and I made it look overly complicated by at the same time refactoring index.rst).

@elbaraim elbaraim merged commit be8ec93 into develop Sep 30, 2020
@elbaraim elbaraim deleted the references branch September 30, 2020 06:23
@yannikschaelte yannikschaelte mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants