Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to petab test suite changes #362

Merged
merged 3 commits into from
Nov 24, 2020
Merged

update to petab test suite changes #362

merged 3 commits into from
Nov 24, 2020

Conversation

yannikschaelte
Copy link
Member

No description provided.

@yannikschaelte yannikschaelte changed the base branch from master to develop November 23, 2020 22:34
Copy link

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end, but I think @dweindl is more familiar with the code

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #362 (ce9a57a) into develop (10dfe65) will increase coverage by 33.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #362       +/-   ##
============================================
+ Coverage    49.65%   83.57%   +33.92%     
============================================
  Files           87       87               
  Lines         5017     5017               
============================================
+ Hits          2491     4193     +1702     
+ Misses        2526      824     -1702     
Impacted Files Coverage Δ
pyabc/sampler/multicore_evaluation_parallel.py 100.00% <0.00%> (+1.63%) ⬆️
pyabc/sampler/base.py 94.82% <0.00%> (+1.72%) ⬆️
pyabc/sampler/redis_eps/cli.py 80.00% <0.00%> (+2.14%) ⬆️
pyabc/random_variables.py 65.87% <0.00%> (+2.38%) ⬆️
pyabc/storage/bytes_storage.py 100.00% <0.00%> (+3.33%) ⬆️
pyabc/inference/smc.py 94.84% <0.00%> (+3.86%) ⬆️
pyabc/inference/util.py 96.96% <0.00%> (+4.04%) ⬆️
pyabc/distance/base.py 83.33% <0.00%> (+4.16%) ⬆️
pyabc/sampler/multicorebase.py 97.56% <0.00%> (+4.87%) ⬆️
pyabc/epsilon/base.py 92.00% <0.00%> (+8.00%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10dfe65...ce9a57a. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 9c98905 into develop Nov 24, 2020
@yannikschaelte yannikschaelte deleted the fix_petabsuite branch November 24, 2020 09:04
@yannikschaelte yannikschaelte mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants