-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings for scipy and laplace prior. #1228
Conversation
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1228 +/- ##
============================================
- Coverage 88.16% 71.92% -16.24%
============================================
Files 79 148 +69
Lines 5257 11863 +6606
============================================
+ Hits 4635 8533 +3898
- Misses 622 3330 +2708 ☔ View full report in Codecov by Sentry. |
How does this affect optimization? i.e. does the gradient then become |
Yes. I am not sure whether this is really a problem in practice. I'd guess it's rather unlikely that the optimizer steps exactly on the mean.
Also fine with me. |
Closes #1189.
Error should only appear for priors? Otherwise could also throw a general error, but not sure how helpful that one would be.