PetabImporter: version-specific amici model directories #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use different directories for models from different amici versions
(e.g., `amici_models/0.20.0/{model_name}` instead of `amici_models/{model_name}`).
Allows switching between amici versions without version errors or re-importing the model.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1283 +/- ##
============================================
- Coverage 84.33% 67.85% -16.49%
============================================
Files 152 152
Lines 12420 12420
============================================
- Hits 10474 8427 -2047
- Misses 1946 3993 +2047 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different directories for models from different amici versions (e.g.,
amici_models/0.20.0/{model_name}instead ofamici_models/{model_name}). Allows switching between amici versions without version errors or re-importing the model.(We could also include the architecture, if considered helpful.)