Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ipopt with gradient approximation #1310

Merged
merged 11 commits into from
Mar 1, 2024
Merged

Support ipopt with gradient approximation #1310

merged 11 commits into from
Mar 1, 2024

Conversation

MerktSimon
Copy link
Contributor

Ipopt supports approximation of Jacobian/Gradients. With this PR pyPESTO will support it, too (fixes #1284).

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.31%. Comparing base (312f43a) to head (d555910).

Files Patch % Lines
pypesto/optimize/optimizer.py 78.04% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1310       +/-   ##
============================================
- Coverage    83.14%   53.31%   -29.83%     
============================================
  Files          153      153               
  Lines        12451    12459        +8     
============================================
- Hits         10352     6643     -3709     
- Misses        2099     5816     +3717     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, as discussed would probably good to have a small test for this.

pypesto/optimize/optimizer.py Outdated Show resolved Hide resolved
@MerktSimon
Copy link
Contributor Author

MerktSimon commented Feb 29, 2024

just added a test. Not sure what the failing julia test has to do with it.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@MerktSimon MerktSimon merged commit f9231f2 into develop Mar 1, 2024
18 checks passed
@MerktSimon MerktSimon deleted the fix_1284 branch March 1, 2024 10:12
@PaulJonasJost PaulJonasJost mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants