basic sanity checking for parameter fixing #420

FFroehlich · 2020-06-29T20:05:17Z

really easy to mix up x_fixed_vals and x_fixed_indices.

codecov-commenter · 2020-07-10T16:32:06Z

Codecov Report

Merging #420 into develop will increase coverage by 0.13%.
The diff coverage is 94.87%.

@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
+ Coverage    91.04%   91.18%   +0.13%     
===========================================
  Files           69       69              
  Lines         3921     3937      +16     
===========================================
+ Hits          3570     3590      +20     
+ Misses         351      347       -4

Impacted Files	Coverage Δ
pypesto/problem.py	`91.87% <94.87%> (+0.20%)`	⬆️
pypesto/engine/multi_process.py	`84.61% <0.00%> (-7.70%)`	⬇️
pypesto/objective/amici_calculator.py	`95.52% <0.00%> (+1.49%)`	⬆️
pypesto/sample/geweke_test.py	`94.36% <0.00%> (+2.81%)`	⬆️
pypesto/objective/amici_util.py	`87.34% <0.00%> (+5.06%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75951ca...6e3e8a4. Read the comment docs.

yannikschaelte

makes sense. is it possible to still have the, e.g. fixed values to be an int list? I think it would be good to still allow passing ints there which are then converted to float. maybe add a test?

yannikschaelte · 2020-07-14T07:26:59Z

pypesto/problem.py

+                                valuename: str,
+                                convtype: str) -> Union[float, int]:
+    """
+    Converts values to the requested type, raises and appropriate error if


Suggested change

Converts values to the requested type, raises and appropriate error if

Converts values to the requested type, raises an appropriate error if

FFroehlich · 2020-07-14T14:25:58Z

makes sense. is it possible to still have the, e.g. fixed values to be an int list? I think it would be good to still allow passing ints there which are then converted to float. maybe add a test?

Yes, should still be possible. Will add test.

FFroehlich · 2020-07-14T16:55:10Z

turned out that tests were quite helpful in squashing a couple more bugs.

dweindl · 2020-07-14T16:56:29Z

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- test/test_problem.py  4
         

Complexity decreasing per file
==============================
+ pypesto/problem.py  -1

See the complete overview on Codacy

* Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info>

* Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info>

* V 021 (#455) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * fix flake8 Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info>

* Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * V 021 (#455) (#456) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Feature cmaes (#457) * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * integration of cma-es optimizer * updated version * updated version * Update setup.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * fix flake8 Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com> * Plot convergence summary and update outdated notebook (#446) * update severely outdated example notebook * add convergence visualization * fix nans * fix flake * update docstring * use problem.get_reduced_vector * fix typehints + docstring * Update pypesto/visualize/optimizer_convergence.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * add to notebook, fix scale, add grad to vis test Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix type checks visualization reference points (#460) * fix for new amici release (#469) * fix for new amici release * update amici requirement * allow longer travis wait time Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com> * fix arguments dlib (#466) (closes #465) * fix arguments ipopt * update docu minimize fct. * fix test_sbml_conversion.py Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * numpy based subindexing in amici_util (#462) * Update amici_util.py * add return doc * fixups * fix test * fix for non-unique par_opt_slice * reduce function complexity * add check for installation ipopt (#470) closes #468 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * check optional requirements amici/petab in PEtab import (#477) * add maxiter to Dlibs default options fixes #474 (#476) * add maxiter to Dlibs default options * Update pypesto/optimize/optimizer.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix y_limits in waterfall plot for list of result objects (#475) * prepare v022 (#479) * prepare v022 * fix review suggestions * Fix merge conflicts (#481) * V 021 (#455) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * fix flake8 Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: PhilippStaedter <42141163+PhilippStaedter@users.noreply.github.com> Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com>

* release v0.2.2 (#480) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * V 021 (#455) (#456) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Feature cmaes (#457) * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * updated python script with not yet finished integration of cma-es optimizer * integration of cma-es optimizer * updated version * updated version * Update setup.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * updated version * fix flake8 Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com> * Plot convergence summary and update outdated notebook (#446) * update severely outdated example notebook * add convergence visualization * fix nans * fix flake * update docstring * use problem.get_reduced_vector * fix typehints + docstring * Update pypesto/visualize/optimizer_convergence.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * add to notebook, fix scale, add grad to vis test Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix type checks visualization reference points (#460) * fix for new amici release (#469) * fix for new amici release * update amici requirement * allow longer travis wait time Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com> * fix arguments dlib (#466) (closes #465) * fix arguments ipopt * update docu minimize fct. * fix test_sbml_conversion.py Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * numpy based subindexing in amici_util (#462) * Update amici_util.py * add return doc * fixups * fix test * fix for non-unique par_opt_slice * reduce function complexity * add check for installation ipopt (#470) closes #468 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * check optional requirements amici/petab in PEtab import (#477) * add maxiter to Dlibs default options fixes #474 (#476) * add maxiter to Dlibs default options * Update pypesto/optimize/optimizer.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix y_limits in waterfall plot for list of result objects (#475) * prepare v022 (#479) * prepare v022 * fix review suggestions * Fix merge conflicts (#481) * V 021 (#455) * Parameters plot, #418 (#425) * parameters plot, plotting a subset of parameters (#418) * "Variable used before assignment" fixed for parameters plot (#364) * Feature autocorrelation - close #251 (#426) * autocorrelation calculation by sokal * docs * notebook using ess * added ess and ac in result * created ess calculation * rename variable * docs * fix * remove print from test * parameter index in 1d marginal plot * added type * added type * docu * flake8 * Update pypesto/sample/diagnostics.py Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * docs * docs * grammar thingy * handle in get_data_to_plot in visu Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * fix display for least squares solver (#430) fix #429 * basic sanity checking for parameter fixing (#420) * basic sanity checking for parameter fixing * fixup type checks * fixup * fix typehints * fixup & refactor * update doc * fixup * Fix amici error output, fixes #427 (#428) * initial fix * add filter function * unify error and base initialization of return values * Profile options (#419) * change profile indexing to parameter indices instead of boolean indexing * adapt also approximation and test to new profile api Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Prior Example, closes # 434 (#438) * Add notebook prior definition * fix sphinx * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/example/prior_definition.ipynb Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Improve notebook Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Fix offset_y and scale_y in waterfal plot (#441) * Correct offset_y for waterfall plots of result lists * enforce y_limits which show whole data when plotting result lists, if no explicit user input was given * fix nans and infs, deal with possibly different number of optiimzation runs in different result objects * fix 2 typos (#444) Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * Update priors.py (#448) * Fix optimization with priors (#452) * Update priors.py * Update priors.py * Fix PEtab import (Priors) (#454), closes #447 * bugfix + compliance to current PEtab version in prior import * resolve review + flake8 Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * prepare version 0.2.1 * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> * Update doc/releasenotes.rst Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> * fix flake8 Co-authored-by: Jakob Vanhoefer <38346459+jvanhoefer@users.noreply.github.com> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: PhilippStaedter <42141163+PhilippStaedter@users.noreply.github.com> Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com> * fix dublicate * rerun github actions Co-authored-by: Polina Lakrisenko <p.lakrisenko@gmail.com> Co-authored-by: Elba Raimúndez Alvarez <elba.raimundez@helmholtz-muenchen.de> Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com> Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> Co-authored-by: Paul Stapor <paul.stapor@helmholtz-muenchen.de> Co-authored-by: Thomas S. Ligon <tom@thomassligon.info> Co-authored-by: PhilippStaedter <42141163+PhilippStaedter@users.noreply.github.com> Co-authored-by: yannikschaelte <yannik.schaelte@gmail.com>

FFroehlich added 5 commits June 29, 2020 16:04

basic sanity checking for parameter fixing

56ecb84

Merge branch 'develop' into sanity_checking

cf57102

Merge branch 'develop' into sanity_checking

cb5f29d

fixup type checks

c6dc032

fixup

0971df3

FFroehlich requested a review from yannikschaelte July 10, 2020 18:11

FFroehlich added 3 commits July 10, 2020 14:14

fix typehints

d7fb3b2

fixup & refactor

5003405

update doc

7307dbf

yannikschaelte approved these changes Jul 14, 2020

View reviewed changes

FFroehlich added 2 commits July 14, 2020 12:31

Merge branch 'develop' into sanity_checking

55f48ea

fixup

6e3e8a4

FFroehlich merged commit f8294db into develop Jul 14, 2020

FFroehlich deleted the sanity_checking branch July 14, 2020 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

basic sanity checking for parameter fixing #420

basic sanity checking for parameter fixing #420

FFroehlich commented Jun 29, 2020

codecov-commenter commented Jul 10, 2020 •

edited

Loading

yannikschaelte left a comment

yannikschaelte Jul 14, 2020

FFroehlich commented Jul 14, 2020

FFroehlich commented Jul 14, 2020

dweindl commented Jul 14, 2020

	Converts values to the requested type, raises and appropriate error if
	Converts values to the requested type, raises an appropriate error if

basic sanity checking for parameter fixing #420

basic sanity checking for parameter fixing #420

Conversation

FFroehlich commented Jun 29, 2020

codecov-commenter commented Jul 10, 2020 • edited Loading

Codecov Report

yannikschaelte left a comment

Choose a reason for hiding this comment

yannikschaelte Jul 14, 2020

Choose a reason for hiding this comment

FFroehlich commented Jul 14, 2020

FFroehlich commented Jul 14, 2020

dweindl commented Jul 14, 2020

codecov-commenter commented Jul 10, 2020 •

edited

Loading