Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature synthetic data #482

Merged
merged 12 commits into from
Oct 26, 2020
Merged

Feature synthetic data #482

merged 12 commits into from
Oct 26, 2020

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Oct 6, 2020

To use this, the feature_synthetic_data branch of AMICI and PEtab (and pyPESTO for the example) should be used together.
Implementation in AMICI: PR
Example optimisation with synthetic data: notebook, PR
PEtab base class: code, PR

@codecov-io
Copy link

Codecov Report

Merging #482 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
+ Coverage    90.49%   90.52%   +0.02%     
===========================================
  Files           70       70              
  Lines         4062     4062              
===========================================
+ Hits          3676     3677       +1     
+ Misses         386      385       -1     
Impacted Files Coverage Δ
pypesto/objective/amici_util.py 83.92% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2941bb5...e35c17e. Read the comment docs.

@dilpath dilpath marked this pull request as ready for review October 14, 2020 20:04
@dilpath
Copy link
Member Author

dilpath commented Oct 14, 2020

Ready for review, but merging will be delayed as this PR requires the next AMICI release

setup.py Outdated Show resolved Hide resolved
doc/example/synthetic_data.ipynb Show resolved Hide resolved
@dilpath
Copy link
Member Author

dilpath commented Oct 21, 2020

This PR is now in a state that I would merge (if approved)

@dilpath dilpath merged commit 6534c87 into develop Oct 26, 2020
@dilpath dilpath deleted the feature_synthetic_data branch October 26, 2020 12:39
@yannikschaelte yannikschaelte mentioned this pull request Jan 19, 2021
m-philipps pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants