do not save empty arrays #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Complexity increasing per file
==============================
- pypesto/store/save_to_hdf5.py 1
See the complete overview on Codacy |
plakrisenko
commented
Oct 28, 2020
| @@ -59,7 +59,9 @@ def write(self, problem, overwrite: bool = False): | |||
| for problem_attr in attrs_to_save: | |||
| value = getattr(problem, problem_attr) | |||
| if isinstance(value, (list, np.ndarray)): | |||
| write_array(problem_grp, problem_attr, value) | |||
There was a problem hiding this comment.
in case of an empty array the first condition in the if statement of write_array will be true, so all empty ones will be saved as int arrays. This messes up shape for example.
Merged
m-philipps
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Prettify reaction arrows * added Erikas comments * Simons comments * Highlight URLs in pdf * chmod +x compile_tutorial.sh * rewrap, typo Co-authored-by: LeonardSchmiester <leonard.schmiester@helmholtz-muenchen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.