Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adapt to changes in PEtab test suite API #508

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 18, 2020

Fix test.test_petab_suite:test_petab_suite.py:35 load_solution() missing 1 required positional argument: 'format'

Closes #507

Fix test.test_petab_suite:test_petab_suite.py:35 load_solution() missing 1 required positional argument: 'format'

Closes #507
@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #508 (3a94c58) into develop (a7439ae) will decrease coverage by 0.03%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #508      +/-   ##
===========================================
- Coverage    90.27%   90.24%   -0.04%     
===========================================
  Files           72       72              
  Lines         4289     4283       -6     
===========================================
- Hits          3872     3865       -7     
- Misses         417      418       +1     
Impacted Files Coverage Δ
pypesto/visualize/misc.py 84.93% <50.00%> (-0.41%) ⬇️
pypesto/visualize/clust_color.py 91.25% <66.66%> (-1.06%) ⬇️
pypesto/optimize/optimizer.py 87.32% <100.00%> (+0.03%) ⬆️
pypesto/visualize/parameters.py 91.91% <100.00%> (ø)
pypesto/visualize/waterfall.py 93.82% <100.00%> (-2.77%) ⬇️
pypesto/engine/multi_process.py 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1705be0...3a94c58. Read the comment docs.

@FFroehlich FFroehlich merged commit 37470b4 into develop Nov 18, 2020
@FFroehlich FFroehlich deleted the fix_507_petabtests branch November 18, 2020 18:24
@dweindl dweindl linked an issue Nov 18, 2020 that may be closed by this pull request
@yannikschaelte yannikschaelte mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Petab testsuite broken
3 participants