Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading problem.x_names from HDF5 #528

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix reading problem.x_names from HDF5 #528

merged 2 commits into from
Dec 2, 2020

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2020

From h5py 3.0.0 on, strings are read as bytes instrad of str, so we need to convert.

From h5py 3.0.0 on, strings are read as `bytes` instrad of `str`, so we need to convert.
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #528 (e50ae7f) into develop (c807d4b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #528      +/-   ##
===========================================
+ Coverage    90.69%   90.71%   +0.02%     
===========================================
  Files           65       65              
  Lines         4212     4212              
===========================================
+ Hits          3820     3821       +1     
+ Misses         392      391       -1     
Impacted Files Coverage Δ
pypesto/store/read_from_hdf5.py 95.34% <100.00%> (ø)
pypesto/optimize/optimizer.py 90.83% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c807d4b...e50ae7f. Read the comment docs.

@dweindl
Copy link
Member Author

dweindl commented Dec 2, 2020

Hm, what's going on with test_unbounded_minimize here? Just plenty of warnings

test_optimization[integrated-optimizer39] seems to fail irregularly / frequently.

@dweindl dweindl merged commit 1aefa58 into develop Dec 2, 2020
@dweindl dweindl deleted the fix_hdf5_strings branch December 3, 2020 09:48
@yannikschaelte yannikschaelte mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants