Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #499 #533

Merged
merged 27 commits into from
Dec 3, 2020
Merged

Fix #499 #533

merged 27 commits into from
Dec 3, 2020

Conversation

elbaraim
Copy link
Member

@elbaraim elbaraim commented Dec 3, 2020

This is a bug that I found while performing sampling. Also reported in #499
In the matlab PESTO, if a failed log posterior evaluation happened, i.e., returning NaN, the log posterior value would be set to -Inf.
This exception was missing in the current pyPESTO implementation, now added.

@elbaraim elbaraim added the bug Something isn't working label Dec 3, 2020
@elbaraim elbaraim self-assigned this Dec 3, 2020
@elbaraim
Copy link
Member Author

elbaraim commented Dec 3, 2020

something went wrong with merging, I will fix this now, sorry!

elba.raimundez added 2 commits December 3, 2020 12:45
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #533 (6ad4d5d) into develop (1aefa58) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
+ Coverage    90.76%   90.79%   +0.02%     
===========================================
  Files           65       65              
  Lines         4212     4214       +2     
===========================================
+ Hits          3823     3826       +3     
+ Misses         389      388       -1     
Impacted Files Coverage Δ
pypesto/sample/metropolis.py 97.36% <50.00%> (-1.29%) ⬇️
pypesto/engine/multi_process.py 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aefa58...6ad4d5d. Read the comment docs.

@elbaraim
Copy link
Member Author

elbaraim commented Dec 3, 2020

something went wrong with merging, I will fix this now, sorry!

now should be fine to review 👍

@elbaraim elbaraim merged commit b68522a into develop Dec 3, 2020
@elbaraim elbaraim deleted the fix_499 branch December 3, 2020 19:46
@yannikschaelte yannikschaelte mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants