Feature misc jv #547
Merged
Feature misc jv #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #547 +/- ##
===========================================
- Coverage 90.91% 87.19% -3.72%
===========================================
Files 69 69
Lines 4403 4405 +2
===========================================
- Hits 4003 3841 -162
- Misses 400 564 +164
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Jan 13, 2021
| @@ -577,7 +579,9 @@ def minimize( | |||
| ub = problem.ub | |||
| if pyswarm is None: | |||
| raise ImportError( | |||
| "This optimizer requires an installation of pyswarm.") | |||
| "This optimizer requires an installation of pyswarm.You can " | |||
There was a problem hiding this comment.
Suggested change
| "This optimizer requires an installation of pyswarm.You can " | |
| "This optimizer requires an installation of pyswarm. You can " |
pypesto/optimize/optimizer.py
Outdated
| @@ -641,7 +645,9 @@ def minimize( | |||
|
|
|||
| if cma is None: | |||
| raise ImportError( | |||
| "This optimizer requires an installation of cma.") | |||
| "This optimizer requires an installation of cma. You can " | |||
| "install cma via pip install cma." | |||
There was a problem hiding this comment.
Suggested change
| "install cma via pip install cma." | |
| "install cma via `pip install cma`." |
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
dweindl
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fidesis installed and throws a meaningful error message...