Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waterfall plot start indices fix #554

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Conversation

plakrisenko
Copy link
Member

No description provided.

@jvanhoefer
Copy link
Member

if you merge this, before the new version is out, please enter this to the releasenote.rst before merging :)

@codecov-io
Copy link

Codecov Report

Merging #554 (ca793d6) into develop (ad2433b) will decrease coverage by 6.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #554      +/-   ##
===========================================
- Coverage    89.68%   83.06%   -6.62%     
===========================================
  Files           71       71              
  Lines         4536     4536              
===========================================
- Hits          4068     3768     -300     
- Misses         468      768     +300     
Impacted Files Coverage Δ
pypesto/visualize/waterfall.py 96.29% <100.00%> (+2.46%) ⬆️
pypesto/petab/pysb_importer.py 0.00% <0.00%> (-100.00%) ⬇️
pypesto/prediction/amici_predictor.py 14.08% <0.00%> (-83.10%) ⬇️
pypesto/prediction/prediction.py 22.50% <0.00%> (-72.50%) ⬇️
pypesto/startpoint/util.py 50.00% <0.00%> (-35.00%) ⬇️
pypesto/optimize/optimizer.py 56.83% <0.00%> (-33.79%) ⬇️
pypesto/objective/amici_util.py 74.10% <0.00%> (-10.72%) ⬇️
pypesto/objective/amici_calculator.py 86.66% <0.00%> (-6.67%) ⬇️
pypesto/sample/pymc3.py 87.87% <0.00%> (-6.07%) ⬇️
pypesto/sample/theano.py 70.27% <0.00%> (-5.41%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2433b...ca793d6. Read the comment docs.

@plakrisenko plakrisenko merged commit 14f1066 into develop Jan 24, 2021
@yannikschaelte yannikschaelte deleted the waterfall_start_indices_fix branch March 11, 2021 22:28
@yannikschaelte yannikschaelte mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants