Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nlopt optimization test by ignoring it #559

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Conversation

yannikschaelte
Copy link
Member

One of the algorithms (GD_STOGO_RAND, id 9) failed in like 40% of the cases with a non-finite return value. Therefore ignoring. Needs to be investigated if someone wants to use that exact algorithm.

@jvanhoefer
Copy link
Member

a) do you want to push into master or into develop?
b) do you see this as a short term or long term solution?

@yannikschaelte yannikschaelte changed the base branch from master to develop January 20, 2021 11:35
@yannikschaelte
Copy link
Member Author

Thanks, develop should have been the target. I see it as a solution until someone complains, bc probably that specific optimizer is just not too robust.

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #559 (df39a8c) into develop (53a1e1b) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #559      +/-   ##
===========================================
- Coverage    89.73%   89.51%   -0.23%     
===========================================
  Files           71       71              
  Lines         4532     4532              
===========================================
- Hits          4067     4057      -10     
- Misses         465      475      +10     
Impacted Files Coverage Δ
pypesto/objective/amici_util.py 75.89% <0.00%> (-8.93%) ⬇️
pypesto/objective/amici_calculator.py 91.66% <0.00%> (-1.67%) ⬇️
pypesto/optimize/optimizer.py 90.61% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a1e1b...df39a8c. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 22c0d42 into develop Jan 20, 2021
@yannikschaelte yannikschaelte deleted the fixes_ys branch January 20, 2021 14:55
@yannikschaelte yannikschaelte mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants