Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong default bounds for parameters plot #601

Merged
merged 6 commits into from
Mar 17, 2021
Merged

Conversation

yannikschaelte
Copy link
Member

@yannikschaelte yannikschaelte commented Mar 17, 2021

fixes #595

Copy link
Contributor

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #601 (fddb1df) into develop (160c2a8) will increase coverage by 1.20%.
The diff coverage is 85.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
+ Coverage    88.16%   89.37%   +1.20%     
===========================================
  Files           79       91      +12     
  Lines         5257     5732     +475     
===========================================
+ Hits          4635     5123     +488     
+ Misses         622      609      -13     
Impacted Files Coverage Δ
pypesto/ensemble/covariance_analysis.py 18.36% <0.00%> (-0.39%) ⬇️
pypesto/objective/amici.py 85.56% <20.00%> (-4.27%) ⬇️
pypesto/predict/task.py 43.75% <43.75%> (ø)
pypesto/engine/mpi_pool.py 66.66% <66.66%> (ø)
pypesto/ensemble/constants.py 91.30% <71.42%> (-8.70%) ⬇️
pypesto/visualize/misc.py 82.41% <72.22%> (-2.52%) ⬇️
pypesto/visualize/waterfall.py 96.34% <77.77%> (+0.04%) ⬆️
pypesto/optimize/optimizer.py 90.37% <81.81%> (-0.11%) ⬇️
pypesto/sample/util.py 86.36% <86.36%> (ø)
pypesto/ensemble/ensemble.py 81.18% <88.88%> (+0.41%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b4c11...fddb1df. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 046e4d8 into develop Mar 17, 2021
@yannikschaelte yannikschaelte deleted the fixes_ys branch March 17, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants