progress bar #641
Merged
progress bar #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #641 +/- ##
===========================================
+ Coverage 88.16% 89.84% +1.67%
===========================================
Files 79 93 +14
Lines 5257 5916 +659
===========================================
+ Hits 4635 5315 +680
+ Misses 622 601 -21
Continue to review full report at Codecov.
|
pypesto/engine/mpi_pool.py
Outdated
| @@ -29,14 +31,19 @@ class MPIPoolEngine(Engine): | |||
| def __init__(self): | |||
| super().__init__() | |||
|
|
|||
| def execute(self, tasks: List[Task]): | |||
| def execute(self, tasks: List[Task], progress_bar: bool = True): | |||
| """Pickle tasks and distribute work to workers.""" | |||
There was a problem hiding this comment.
Would add a Parameter description here for progress_bar in the docstring. Same in the others.
yannikschaelte
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP on giving optimization/Ensembles/Profiles a nice little progress bar...