Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sorting to appending. closes #378 #668

Merged
merged 1 commit into from
May 17, 2021

Conversation

PaulJonasJost
Copy link
Collaborator

closes #378

sorting when reading from file (at least for hdf5) is already enforced.

@PaulJonasJost PaulJonasJost linked an issue May 14, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #668 (9f9826c) into develop (4fd93af) will increase coverage by 44.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #668       +/-   ##
============================================
+ Coverage    42.98%   87.54%   +44.55%     
============================================
  Files           95       95               
  Lines         6134     6135        +1     
============================================
+ Hits          2637     5371     +2734     
+ Misses        3497      764     -2733     
Impacted Files Coverage Δ
pypesto/result.py 88.67% <100.00%> (+29.06%) ⬆️
pypesto/predict/result.py 33.33% <0.00%> (-61.12%) ⬇️
pypesto/ensemble/utils.py 21.21% <0.00%> (-36.37%) ⬇️
pypesto/petab/importer.py 70.25% <0.00%> (-15.19%) ⬇️
pypesto/predict/amici_predictor.py 82.71% <0.00%> (-14.82%) ⬇️
pypesto/objective/amici_util.py 75.43% <0.00%> (-7.02%) ⬇️
pypesto/petab/pysb_importer.py 73.33% <0.00%> (-6.67%) ⬇️
pypesto/objective/amici_calculator.py 90.00% <0.00%> (ø)
pypesto/objective/base.py 87.71% <0.00%> (+2.33%) ⬆️
pypesto/startpoint/util.py 87.50% <0.00%> (+2.50%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd93af...9f9826c. Read the comment docs.

@PaulJonasJost PaulJonasJost merged commit 5b62113 into develop May 17, 2021
@PaulJonasJost PaulJonasJost deleted the feature_sort_optimize_result_when_appending branch May 17, 2021 12:01
@yannikschaelte yannikschaelte mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptimizeResult: Strictly enforce sorting, or not at all
3 participants