Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add petab linter to petab import closes #677 #678

Merged
merged 2 commits into from
May 28, 2021

Conversation

jvanhoefer
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #678 (a4903f1) into develop (0461449) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #678      +/-   ##
===========================================
- Coverage    88.13%   88.05%   -0.08%     
===========================================
  Files           96       96              
  Lines         6363     6365       +2     
===========================================
- Hits          5608     5605       -3     
- Misses         755      760       +5     
Impacted Files Coverage Δ
pypesto/petab/importer.py 70.00% <50.00%> (-0.26%) ⬇️
pypesto/engine/multi_process.py 92.59% <0.00%> (-7.41%) ⬇️
pypesto/optimize/optimizer.py 89.63% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0461449...a4903f1. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@yannikschaelte yannikschaelte merged commit a4a2070 into develop May 28, 2021
@yannikschaelte yannikschaelte deleted the feature_petab_lint branch May 28, 2021 09:23
@jvanhoefer jvanhoefer linked an issue May 31, 2021 that may be closed by this pull request
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run PEtab linter in PEtab import
3 participants