Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only HDF5 file access for Hdf5History.__len__ #679

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 28, 2021

That function doesn't need write access to the history file and unnecessarily prevents parallel access.
Changing to read-only.

That function doesn't need write access to the history file and unnecessarily prevents parallel access.
Changing to read-only.
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry that is on me. Thanks for the fix 👍

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #679 (eb86010) into develop (a4a2070) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #679   +/-   ##
========================================
  Coverage    90.32%   90.32%           
========================================
  Files           96       96           
  Lines         6366     6366           
========================================
  Hits          5750     5750           
  Misses         616      616           
Impacted Files Coverage Δ
pypesto/objective/history.py 95.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a2070...eb86010. Read the comment docs.

@yannikschaelte
Copy link
Member

@PaulJonasJost had fixed it swhere else already, but twice is better

@PaulJonasJost
Copy link
Collaborator

@PaulJonasJost had fixed it swhere else already, but twice is better

Oh yes you are right :D but the PR is still open.

@dweindl dweindl merged commit 09eab00 into develop May 28, 2021
@dweindl dweindl deleted the fix_hdf5_a branch May 28, 2021 14:34
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants